Fix off-by-one in InsertAndShift resize condition (#2291)#2292
Merged
JanKallman merged 1 commit intodevelop8from Feb 22, 2026
Merged
Fix off-by-one in InsertAndShift resize condition (#2291)#2292JanKallman merged 1 commit intodevelop8from
JanKallman merged 1 commit intodevelop8from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in
ChangeableDictionary.InsertAndShiftwhere the array resize condition was checkingpos + 1 >= Length - 1instead of_count >= Length - 1. This caused anArgumentExceptionwhen callingInsertColumnon xlsx files where the number of defined columns was at the array boundary.This PR also includes a unit test that replicated the issue and verifies the fix.